-
Notifications
You must be signed in to change notification settings - Fork 6
Ak adjust westend and tests #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| assert_ok!(res); | ||
| assert_ok!(res.unwrap()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antkve when 8 (or 9) passes, then I would add here one more store with construct_and_apply_extrinsic, which should fail because of // 10 MiB (allows 9 MiB for normal transactions with 90% NORMAL_DISPATCH_RATIO), right?
We should also cover check_proof in block, so the ultimate test case would be like:
- successfully submit `check_proof` tx (later (as follow-up, when we merge [configurable StoragePeriod](https://github.com/paritytech/polkadot-sdk/pull/10662)), we should advance blocks so the full block is hit by `check_proof` ) (maybe we will need to tune `NORMAL_DISPATCH_RATIO` because of this)
- 8-9x submit **successfully** `construct_and_apply_extrinsic(store)`
- the last submit `construct_and_apply_extrinsic(store)` should fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkontur Okay but at the moment we'd need to advance it for the whole set storage period to call check_proof. Should I do that or just leave a TODO for when configurable StoragePeriod is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkontur Okay but at the moment we'd need to advance it for the whole set storage period to call check_proof. Should I do that or just leave a TODO for when configurable StoragePeriod is merged?
Create follow-up issue and TODO please
Partially implements: #144